chore: prune 6 dead exports in src/lib - #1296
Merged
Merged
Conversation
Deep-audit confirmed via grep across the full repo (src/, harnesses/, worker/, scripts/, packages/): Fully deleted (0 refs anywhere): - src/lib/time-constants.ts: MS_PER_SECOND, MS_PER_MINUTE, MS_PER_HOUR, MS_PER_DAY — never imported. SECONDS_PER_* stay (used by scales.ts). Un-exported (only used internally in their own file): - src/lib/search-featured.ts: FEATURED_SLUGS re-exported ALL_SLUGS but the alias itself had no external consumer. - src/lib/categories.ts: CATEGORY_SLUG_BY_LABEL feeds only categorySlugFromLabel() one line below. - src/lib/dataset-jsonld.ts: ZENODO_CONCEPT_DOI and ZENODO_CONCEPT_URL are only used to compose GLOBAL_DATASET_JSONLD and buildBenchDatasetJsonLd() in the same file. - src/lib/materialize/schema.ts: SeriesRingSchema is only referenced by WorkerStateSchema's type inference (the SeriesRing type export stays — worker/index.ts imports it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second pass from the audit. Only touches exports that were verified via grep across the FULL repo (src/, harnesses/, worker/, scripts/, packages/, benchmarks/) to have zero external consumers.
Fully deleted
MS_PER_SECOND,MS_PER_MINUTE,MS_PER_HOUR,MS_PER_DAYfromtime-constants.ts— never imported anywhere.SECONDS_PER_*counterparts stay (used byscales.ts).Un-exported (still used internally, just no longer public)
FEATURED_SLUGS(search-featured.ts) — was aliasingALL_SLUGSwith no external consumerCATEGORY_SLUG_BY_LABEL(categories.ts) — feeds onlycategorySlugFromLabel()one line belowZENODO_CONCEPT_DOI+ZENODO_CONCEPT_URL(dataset-jsonld.ts) — only composeGLOBAL_DATASET_JSONLDandbuildBenchDatasetJsonLd()in the same fileSeriesRingSchema(materialize/schema.ts) — only referenced byWorkerStateSchematype inference. TheSeriesRingtype export stays becauseworker/index.tsimports it.Verified false positives from the audit (kept)
PM_VENUE_META,PERP_VENUE_META,PmVenueContext,PerpVenueContext,PERP_VENUES,HF_DATASET_URL,DATASET_LICENSE,CREATOR_PUBLISHER,CITABLE_JSON_URL,GLOBAL_DATASET_JSONLD,MAT_SCHEMA_VERSION,FRESH_MAX_MS,STALE_MAX_MS,WorkerStateSchema,MaterializedSnapshotSchema— all have real consumers (products pages, dataset JSON-LD builders, or the worker).Test plan
bun run typecheck— cleanbun run validate— 75 specs valid