drop token-trade-coverage (bench 090): self-baseline bias - #1385
Merged
Conversation
Self-baseline bias: Mobula pinned at 100% because it returned the highest raw trade counts (more DEXs + counts route splits). Not apple-to-apple. Future rebuild needs RPC-derived ground truth. Spec + harness removed, slug added to REMOVED_BENCH_SLUGS (410 on prod). Bumped bench-unfiltered v43->v44 + all-benchmarks v46->v47.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops bench 090 entirely.
Why: the union-of-providers baseline made Mobula the ceiling — Mobula systematically returned the highest raw trade counts (indexes more DEXs + counts every leg of cross-aggregator route splits as separate trades). Result: Mobula pinned at 100%, Codex/Bitquery at 40-70% not because they lag but because they dedup differently. Framing 'capture rate' implied ground-truth completeness we did not have.
A future rebuild would need RPC-derived ground truth (walk block explorer, dedup by tx_hash + log_index). Until then, the bench is not apple-to-apple.
Changes
Post-merge: also stop + remove the harness container on VPS (`ocb-token-trade-coverage`) and its Prom scrape.