cherry-pick: wormhole ms fix to main - #1389
Merged
Merged
Conversation
Site display bug: harness emitted latency in seconds (4.25s BNB p50), but the site formatter divides all latency histograms by 1000 to convert its internal ms to display seconds. 4.25s / 1000 = 0.00425s rendered as '0.0 s' across all 4 rows. Fix: rename metric wormhole_vaa_latency_seconds -> _milliseconds, emit delta * 1000, scale buckets 1000x (2s -> 2000ms etc). Update spec queries to point at the new metric names. Bump cache keys v44->v45, v47->v48. Existing metric samples become orphaned; new samples start populating the correct series immediately. Diff: metrics.go rename + main.go .Seconds() -> .Milliseconds() + spec sed s/_seconds/_milliseconds/g + unit: s -> ms + cache key bump. Bench YAML rest unchanged. Co-authored-by: Florent Tapponnier <contact@mobula.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1388.