chart watermark v2: diagonal DefiLlama-style + download button confirmation icon - #1437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tweaks after live feedback on the initial ship (#1434).
Watermark → diagonal middle
Moved from bottom-right corner (opacity 0.28, easy to crop out) to plot center, rotated -22°, larger font (16% of plot's shorter axis), opacity 0.09. Mirrors DefiLlama's viral-loop watermark. Rendered BEFORE data paths so lines/bars stack on top — reads as a background stamp, never competes with data during normal reading, always survives screenshots including tight crops.
Download button now shows a check on success
Split state (`copied` / `downloaded` / `error`) so the Copy button doesn't fake a "Copied" when the user actually pressed Download. The download icon flips to a check for 1.6s after the file lands.