Skip to content

jsonld: replace remaining @id-only refs with Thing/inline (chain + alt pages) #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jul 25, 2026
Merged

jsonld: replace remaining @id-only refs with Thing/inline (chain + alt pages) #1443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/app/alternatives/[slug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@ export default async function AlternativePage({
...(citableAsOf(bench) ? { dateModified: bench.lastRunAt } : {}),
author: { "@id": `${SITE.url}/#org` },
publisher: { "@id": `${SITE.url}/#org` },
about: { "@id": `${url}#dataset` },
// `about` describes the topic. Use a Thing rather than @id-refing
// the same-page Dataset (Google validates @id-only refs as
// standalone incomplete Datasets even within the same @graph).
about: { "@type": "Thing", name: bench.metric },
},
buildBreadcrumbJsonLd([
{ name: "Home", item: SITE.url },
Expand Down
16 changes: 14 additions & 2 deletions src/app/benchmarks/[slug]/[chain]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,20 @@ export default async function BenchmarkChainPage({
author: [{ "@id": PERSON_ID }, { "@id": `${SITE.url}/#org` }],
reviewedBy: { "@id": PERSON_ID },
publisher: { "@id": `${SITE.url}/#org` },
about: { "@id": `${benchmarkUrl}#dataset` },
isPartOf: { "@id": `${benchmarkUrl}#article` },
// `about` describes the topic. Point at the metric as a Thing
// rather than @id-referencing the parent bench Dataset (cross-doc
// @id refs get validated as standalone incomplete Datasets by
// Google, same class of issue as the isPartOf/isBasedOn fixes).
about: { "@type": "Thing", name: benchmark.metric },
// isPartOf: parent bench article. Inline the required fields so
// the reference validates on its own (Google does not stitch
// cross-page @id refs).
isPartOf: {
"@type": "TechArticle",
"@id": `${benchmarkUrl}#article`,
name: benchmark.title,
url: benchmarkUrl,
},
},
buildBreadcrumbJsonLd([
{ name: "Home", item: SITE.url },
Expand Down
7 changes: 6 additions & 1 deletion src/app/benchmarks/[slug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,12 @@ export default async function BenchmarkPage({
author: [{ "@id": PERSON_ID }, { "@id": `${SITE.url}/#org` }],
reviewedBy: { "@id": PERSON_ID },
publisher: { "@id": `${SITE.url}/#org` },
about: { "@id": `${benchmarkUrl}#dataset` },
// `about` describes the topic. Use a Thing (matches the
// StatisticalReport `about` pattern above) rather than @id-refing
// the same-page Dataset. Google's Dataset validator was flagging
// @id-only refs as standalone incomplete Datasets even within
// the same @graph (see the isBasedOn fix in dataset-jsonld.ts).
about: { "@type": "Thing", name: benchmark.metric },
},
buildBreadcrumbJsonLd([
{ name: "Home", item: SITE.url },
Expand Down
Loading