Skip to content

fix: tab 2-click on benches with venue dimension #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jul 26, 2026
Merged

fix: tab 2-click on benches with venue dimension #1502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/benchmark-body.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@
// variantMap intentionally omitted: presence is re-checked inside the
// functional setState, a duplicate in-flight fetch is harmless.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [effectiveChain, effectiveRegion, effectiveKind, aggregateBench]);
}, [effectiveChain, effectiveRegion, effectiveKind, effectiveVenue, aggregateBench]);

const benchmark = variantMap[activeKey] ?? aggregateBench;
// True while the selected chain/region/kind variant is still loading:
Expand Down Expand Up @@ -622,7 +622,7 @@
// not only on the timeseries view. Providers the panel has no value
// for (book could not fill the tier) drop out of the ranking, which
// is the skipped-not-extrapolated rule made visible.
const panelViewBenchmark = useMemo(() => {

Check failure on line 625 in src/components/benchmark-body.tsx

View workflow job for this annotation

GitHub Actions / check 

React Hook "useMemo" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
if (!activePanel) return viewBenchmark;
const vals = activePanel.values ?? {};
return {
Expand Down
2 changes: 1 addition & 1 deletion src/components/chain-tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ function Tab({
{info && (info.providers > 0 || info.leader) && (
<span
role="tooltip"
className="pointer-events-none absolute left-1/2 top-full z-30 mt-1.5 hidden -translate-x-1/2 w-[min(16rem,90vw)] rounded-md border border-rule bg-paper p-2.5 shadow-xl group-hover:block text-left normal-case tracking-normal"
className="pointer-events-none absolute left-1/2 top-full z-30 mt-1.5 hidden -translate-x-1/2 w-[min(16rem,90vw)] rounded-md border border-rule bg-paper p-2.5 shadow-xl [@media(hover:hover)]:group-hover:block text-left normal-case tracking-normal"
>
<p
className="text-[10px] font-medium uppercase tracking-[0.16em]"
Expand Down
Loading