token-quote-coverage: re-add KyberSwap + ParaSwap (they DO emit) - #1597
Merged
Conversation
… comment outdated) Prom on VPS confirms 5 providers with real 24h data: - KyberSwap: 981 attempts, 95.5% on Robinhood, 58.0% on BSC - ParaSwap: 314 attempts, 9.9% on BSC Also update per_chain_explainer (Robinhood cohort: 4 not 2), methodology chain-scope + endpoint list, FAQ EVM-only null-cell wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
User reported only 3 providers on /benchmarks/token-quote-coverage. Prom on VPS confirms the harness emits for 5 providers (24h):
The spec had a stale comment saying "KyberSwap + ParaSwap currently not emitting on the harness" and dropped them from the
providersblock. That comment is wrong — probes have been running for a while, likely since PR #1472 that added Robinhood support to ParaSwap.Changes
kyberswapandparaswapprovider blocks with correct queries and tags (EVM-only: Base + BNB + Robinhood, no API key).Verification
pnpm validate: 94 specs valid (up from 93). No lint/typecheck impact.