Skip to content

fix: static-to-dynamic 500s + thirdweb tripwire #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Aug 3, 2026
Merged

fix: static-to-dynamic 500s + thirdweb tripwire #1746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/alternatives/[slug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { fetchPerpCohort } from "@/lib/perp-stats";
import { loadBenchFromBlob } from "@/lib/bench-blob";
import { PerpVenueBenchCards } from "@/components/perp-venue-bench-cards";

export const revalidate = 60;
export const dynamic = "force-dynamic";

// Same budget as /products/[slug]: on-demand renders span the whole bench
// catalog and the 60s default killed them mid-flight.
Expand Down
22 changes: 13 additions & 9 deletions src/app/products/[slug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import { getPmVenueContext } from "@/lib/pm-venue-context";
import { fetchPmDataFeedKpis } from "@/lib/pm-venue-data";
import { fetchPerpVenueKpis } from "@/lib/perp-venue-data";
import { hasRpcProviderData } from "@/lib/rpc-hub-stats";
import { loadBenchFromBlob } from "@/lib/bench-blob";
import { PmVenueSection } from "@/components/pm-venue-section";
import {
getPerpVenueContext,
Expand Down Expand Up @@ -204,14 +203,20 @@ export default async function ProviderPage({
a.result.availability === "live" &&
a.result.unresponsive !== true,
);
const anyMeasuredAppearance = p.appearances.some(
(a) => (a.result.ms?.p50 ?? 0) > 0,
// Exclude appearances with insufficient data confidence from the
// "any measured" check: a new provider whose every bench appearance is
// still warming up (insufficient sample count) legitimately has rank=0
// everywhere — that is not a degraded store read, it is warm-up state.
const anyConfidentAppearance = p.appearances.some(
(a) =>
(a.result.ms?.p50 ?? 0) > 0 &&
a.result.dataConfidence !== "insufficient",
);
if (
p.appearances.length >= 8 &&
p.appearances.every((a) => a.rank === 0) &&
allClaimLive &&
anyMeasuredAppearance
anyConfidentAppearance
) {
throw new Error(`degraded store read for /products/${slug}: ${p.appearances.length} appearances, all unranked`);
}
Expand All @@ -232,11 +237,10 @@ export default async function ProviderPage({
const pmContext = await getPmVenueContext(p.slug);

// Perp DEX cohort dashboard. Same pattern as the PM context above.
const isPerpSlug = PERP_PRODUCT_PILL_SLUGS.has(p.slug);
const feesAtSizeBench = isPerpSlug
? await loadBenchFromBlob("perp-fees-at-size")
: null;
const perpContext = await getPerpVenueContext(p.slug, feesAtSizeBench);
// perp-fees-at-size bench was removed; pass null so loadBenchFromBlob
// (cache: "no-store") is not called from an ISR page (it would trigger
// Next.js "Page changed from static to dynamic" for polymarket).
const perpContext = await getPerpVenueContext(p.slug, null);

// KPI-domain availability, resolved upfront so the pill bar knows
// every domain before rendering. A pill must never open onto an empty
Expand Down
Loading