fix(l1-finality): exclude stale-gauge rows from ranking + dynamic SEO meta - #1853
Merged
Conversation
… meta - Add MIN_DISPLAY_SUCCESS_PCT=5 in provider-filters; Prom gauges retain last value on harness failure so a chain at 0% success but non-zero stale p50 ranked #1 on lower-is-better benches - Apply filter in ledger-table sortedAll, ranked-bar-chart scored, and [chain]/page sortLive so all display surfaces agree - Guard buildKeyFacts against stale-gauge edge case (p50>0, bad rate) - Add citation_* meta + robots/twitter to per-chain generateMetadata (parity with parent bench page for academic/LLM citation) - seo_description uses {{best_name}}/{{best_p50}} so meta reflects live data instead of a hardcoded chain list
Flotapponnier
force-pushed
the
fix/l1-finality-stale-ranking
branch
from
August 11, 2026 21:52
536c8a7 to
777b5a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MIN_DISPLAY_SUCCESS_PCT = 5 %dansprovider-filters.ts, appliqué dansledger-table,ranked-bar-chartet la page[slug]/[chain].seo_descriptiondel1-finality.ymlutilisait un texte figé. Remplacé par{{best_name}}/{{best_p50}}—renderTemplaterésout ces placeholders depuis les données live à chaque ISR.citation_*meta tags,robotshandling ettwitter.siteàgenerateMetadatade[slug]/[chain]/page.tsx, en parité avec la page parent. Ces pages existent déjà pour tous les chains de l1-finality (bitcoin, ethereum, solana, etc.) et sont dans le sitemap avec priority 0.85.Test plan
/benchmarks/l1-finalityn'affiche plus de chaîne avec 0 % success rate dans le classement/benchmarks/l1-finalitycontient le nom du leader live<head>de/benchmarks/l1-finality/ethereum: presence decitation_doi,citation_title,twitter:site🤖 Generated with Claude Code