fix(sitemap): drop 410'd benches, HL builder /products redirects, empty categories (#980) - #982
Merged
Merged
Conversation
… empty categories (#980) Prod deploy sitemap-smoke rolled back on 4 URLs that the sitemap advertises but which return non-200: https://openchainbench.com/benchmarks/bridge-revenue → 410 https://openchainbench.com/benchmarks/evm-quote-latency → 410 https://openchainbench.com/products/phantom-perps → 307 https://openchainbench.com/benchmarks/category/wallets → 404 Root cause for each: 1. bridge-revenue + evm-quote-latency: middleware returns 410 on prod (REMOVED_BENCH_SLUGS) but their YAML still says status:live, so the sitemap generator still emits them. 2. phantom-perps: it's a tracked HL builder, /products/<slug> redirects to /hyperliquid/<slug>. The sitemap listed the redirect source instead of the canonical target. 3. wallets category: no bench currently declares category:'Wallets' but the CATEGORIES enum still ships the slug; the page component 404s. Fixes (all in src/app/sitemap.ts): - Import REMOVED_BENCH_SLUGS (exported from middleware.ts) and skip them in benchmarkRoutes.flatMap. - Import isHlBuilderSlug and filter validatedSlugs on it in addition to the existing chain-slug filter. - Re-add the liveCategoryLabels filter on categoryRoutes so an empty CATEGORY entry doesn't produce a URL. Middleware unchanged except REMOVED_BENCH_SLUGS is now exported. Co-authored-by: Florent Tapponnier <contact@mobula.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #980. Unblocks prod deploy.