feat(github): implement repository sync engine, paginated listing, commit tracking, and incremental sync - #4
Open
ChamathDilshanC wants to merge 1 commit into
Open
Conversation
…raction, and incremental sync engine
There was a problem hiding this comment.
🟡 Not ready to approve
The sync engine currently only fetches one repo page and silently ignores commit-fetch errors, which can lead to incomplete/incorrect “successful” sync reports.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR introduces a GitHub repository sync layer in the crates/github crate, adding typed clients for listing repositories and fetching commits, plus a sync engine that aggregates results into a report.
Changes:
- Added
RepositorySyncEngine/RepositorySyncReportandSyncTypeto orchestrate repo + commit syncing. - Introduced typed error enums for repository and commit API interactions and refactored clients to return
Result. - Added pagination-related options (
SyncOptions) and commit models, plus basic unit tests.
File summaries
| File | Description |
|---|---|
| crates/github/tests/sync_tests.rs | Adds basic serialization and helper-function tests for new GitHub types. |
| crates/github/src/sync.rs | Implements the repository sync engine and reporting types. |
| crates/github/src/repositories.rs | Adds typed repo client errors, sync options, pagination parameters, and single-repo fetch. |
| crates/github/src/lib.rs | Re-exports new sync and commit/repo client symbols from the crate root. |
| crates/github/src/commits.rs | Adds commit client, typed errors, commit models, and caps commit impact score. |
| crates/github/Cargo.toml | Adds urlencoding workspace dependency for query encoding. |
| Cargo.lock | Locks the new urlencoding dependency. |
Review details
Suppressed comments (1)
crates/github/src/repositories.rs:120
- Same as above:
unwrap_or_default()onresponse.text()hides the reason the body couldn't be read. Preserve that context soApiErroris actionable in logs and error reports.
if !response.status().is_success() {
let status = response.status().as_u16();
let text = response.text().await.unwrap_or_default();
return Err(GitHubRepoError::ApiError(status, text));
- Files reviewed: 6/7 changed files
- Comments generated: 4
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Comment on lines
+90
to
+92
| let status = response.status().as_u16(); | ||
| let text = response.text().await.unwrap_or_default(); | ||
| return Err(GitHubRepoError::ApiError(status, text)); |
Comment on lines
+94
to
+96
| let status = response.status().as_u16(); | ||
| let text = response.text().await.unwrap_or_default(); | ||
| return Err(CommitSyncError::ApiError(status, text)); |
Comment on lines
+56
to
+61
| let start = std::time::Instant::now(); | ||
| let opts = SyncOptions::default(); | ||
|
|
||
| let repos: Vec<GithubRepo> = self.repo_client.fetch_repositories(token, &opts).await?; | ||
| let repo_count = repos.len(); | ||
| let mut total_commits = 0; |
Comment on lines
+75
to
+81
| if let Ok(commits) = self | ||
| .commit_client | ||
| .fetch_commits(token, owner, repo_name, since) | ||
| .await | ||
| { | ||
| total_commits += commits.len(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Closes #
Type of Change
feat— New featurefix— Bug fixrefactor— Refactoring (no functional change)docs— Documentation onlytest— Tests onlychore— Build, CI, dependenciesPre-Merge Checklist
Quality Gates
cargo fmt --checkpassescargo clippy -- -D warningspasses (zero warnings)cargo checkpassescargo testpasses (all tests green)Implementation
.unwrap()or.expect()in production code pathstracing::info!/tracing::error!)thiserrorenum)Tests
Documentation
docs/updated if API surface changeddocs/AI/API_CHECKLIST.mdupdated (mark endpoints ✅)docs/FEATURES.mdupdated (mark feature ✅)Architecture
docs/AI/ARCHITECTURE_RULES.md)ChamathDilshanC <dilshancolonne123@gmail.com>Architecture Impact
None / [describe impact]
Testing Notes
Screenshots (if UI or API response)
Notes for Reviewer