feat(view): map is the default landing view (list when offline) - #27
Merged
Merged
Conversation
The app's edge is times shown ON the map without tapping, so lead with it. Default view when no ?zobrazeni: map if online, seznam if offline (the map needs a connection — the list is the offline-safe path). Explicit ?zobrazeni always wins and now round-trips (setView records the choice). Unit tests updated to start list-journey specs on the seznam explicitly; added map-default (online) and seznam-fallback (offline) landing tests. e2e migration follows. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5AA9dRxCnS1eMCZfxa2bG
…nding The map is now the default landing view when online (list only when offline, per feat(view) abc11c0); every spec that exercises the SEZNAM now navigates with `?zobrazeni=seznam` explicitly instead of relying on a plain `/` landing there. URL round-trip assertions updated to match: setView now always records the choice (?zobrazeni survives a toggle to seznam too, not just mapa), so places that asserted a bare `/` or an unqualified query string needed the explicit param folded in. Also: - map.spec.ts: added a test asserting the new online+geolocation default actually lands on the map, and that the seznam<->mapa toggle round-trips via the URL from there. - map.spec.ts: the seznam/mapa toggle test's cathedral-marker click now targets a corner instead of the computed center — the center sits exactly on a neighboring church's invisible 44px tap-halo (::after, inset -8px); confirmed pre-existing on main via a baseline check, not something this branch introduced. Worth a UX follow-up (halo overlap between close markers can steal a tap) but out of scope here. - preview-video.spec.ts: bounded the map-chip click's own timeout and gave the test more wall-clock room — an unbounded click against real (unmocked) data could eat the whole test budget before its .catch() ever ran, closing the browser mid-tour. - src/App.en.test.tsx: the abc11c0 unit-test migration missed this sibling file; applied the same '/?zobrazeni=seznam' start as App.test.tsx. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5AA9dRxCnS1eMCZfxa2bG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the map the landing view (the app's edge is times ON the map). Default when no ?zobrazeni: map if online, seznam if offline. Explicit ?zobrazeni round-trips. Unit + e2e migrated to be view-explicit; new map-default landing test added.
Tallies on branch: 234 unit + 50 e2e pass, tsc clean.
🤖 Generated with Claude Code