Conversation
… zero workspaces showCreateCard was !isCommunity(), so a community-edition user who owns zero workspaces sees only a static "no workspaces" message with no interactive element to create one. PR ChatbotXIO#405 deliberately hid the card once a workspace already exists (self-hosted installs stay single-workspace), but that change also silently removed the only path into createFirstWorkspace for a brand-new user, since /channels/create is otherwise unreachable from this page. Adds workspaces.length === 0 back to the condition: the card still hides once a workspace exists, matching ChatbotXIO#405's intent, but shows for a user who has none yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1226.
In the
communityedition,showCreateCardwas!isCommunity(), so a user who owns zero workspaces sees only a static "no workspaces" message with no interactive element to create one./channels/create— the entry point intocreateFirstWorkspace— is otherwise unreachable from this page.#405 deliberately hid the card once a workspace already exists (self-hosted installs are meant to stay single-workspace), and that intent is preserved here. What #405 also did, as a side effect, was remove the only path into workspace creation for a user who has none yet — this restores just that case.
Change
Verification
Added
apps/builder/__tests__/workspaces-list.community-zero.test.tsx, two cases: card renders a link to/channels/createat zero workspaces, and stays absent once one exists. Full suite for the touched area:ultracite checkis clean.