Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1240
What changed
--color-destructive-foregroundis registered in@theme inline(so thetext-destructive-foregroundutility exists), but--destructive-foregrounditself was neverdeclared in
:rootor.dark— every other-foregroundcounterpart in the file has both.Added the missing declarations:
The two modes need different foregrounds — white only reads ~2.75:1 against
--destructiveindark mode, so this can't be fixed by hardcoding
text-whiteat the two existing call sites(
prize-list-editor.tsx,sersavan/multi-select.tsx) instead of fixing the token.Verification
Recomputed with standard WCAG 2.x contrast math:
--destructive--destructive(dark)--destructive(dark), to confirm the two modes actually need different foregroundsBoth real pairs clear the 4.5:1 WCAG 1.4.3 text floor.
pnpm --filter @chatbotx.io/ui check-typesandpnpm --filter @chatbotx.io/ui testboth pass(13/13 test files, 56/56 tests) against this change.