Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1241
What changed
@theme inlinedeclared nine custom properties (--tracking-normal,--shadow-2xlthrough--shadow-2xs) asvar()references to themselves. Per the CSS custom-properties spec, aproperty that references itself is invalid at computed-value time and falls back to the
property's initial value (
noneforbox-shadow,normalforletter-spacing) — so everyshadow-*/tracking-*utility, includingbutton.tsx's ownshadow-xs, rendered with novisible effect.
This PR is a pure deletion of the nine circular lines. With them gone, Tailwind CSS 4.3.2's own
built-in defaults (
tailwindcss/theme.css) apply automatically.Verification
Compiled
default.csswith Tailwind CSS 4.3.2 (@tailwindcss/postcss) against a template usingshadow-xsandtracking-wide, before and after:.shadow-xscompiledbox-shadowvar(--shadow-xs), computednone0 1px 2px 0 rgb(0 0 0 / 0.05)(real shadow)--tracking-normalvar(--tracking-normal)(circular)0em.tracking-widecomputedletter-spacingnormalcalc(0em + 0.025em)pnpm --filter @chatbotx.io/ui check-typesandpnpm --filter @chatbotx.io/ui testboth pass(13/13 test files, 56/56 tests) against this change.
Note
If the intent was custom (non-default) shadow/tracking values rather than Tailwind's stock
defaults, the maintainer may prefer literal values instead of a plain deletion — happy to adjust.