fix(api-channel): map delivery-status messageId to the worker's messageSourceId - #1249
Open
Uncle-Lou-AfterShockFam wants to merge 1 commit into
Conversation
…geSourceId
POST /api/v1/channels/api/delivery-status accepts { messageId, status,
timestamp, error } and answers 204, then enqueues the payload verbatim to
the integration worker, whose messageStatus handler validates
{ messageSourceId, status }. Every status therefore failed with
ZodError "messageSourceId: expected string, received undefined" and the
hub never recorded delivered/failed for an API channel. Map the field at
the enqueue site so the public contract stays unchanged.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/v1/channels/api/delivery-statusaccepts{ messageId, status, timestamp, error }and answers 204, then enqueues the payload verbatim to the integration worker. The worker'smessageStatushandler validates{ messageSourceId, status }(integrations/api/src/handlers/message/outgoing-message.ts), so every accepted status died in the worker withZodError: messageSourceId: expected string, received undefinedand the hub never recorded delivered/failed for an API channel.This maps the field at the enqueue site so the public contract stays unchanged.
How it was found
A self-hosted instance driving an external SMS line through an API channel: the public endpoint returned 204 for every
delivered/failedreport, the worker log showed the ZodError for each, andMessagerows never leftsent. With the patch applied to the builder image the statuses land.Test plan
1b71fc4: 204 + worker ZodError before, status recorded after.apps/builder/__tests__suite for the integration-api router covers the 204 path; a worker-side assertion on the enqueued payload shape would pin this.🤖 Generated with Claude Code