Conversation
2 tasks
Contributor
|
하진님, 수고하셨습니다 |
junhakjh
reviewed
Jan 9, 2025
| export { LeftArrowIcon, RightArrowIcon, UpArrowIcon, DownArrowIcon }; | ||
| const RightBottomArrowIcon: React.FC<PArrowIcon> = () => { | ||
| return ( | ||
| <svg width='23' height='24' viewBox='0 0 23 24' fill='none' xmlns='http://www.w3.org/2000/svg'> |
Contributor
There was a problem hiding this comment.
width와 height의 비율이 1:1이 아닌 것은 의도된 부분인가요?
| import { TTier } from '@/model/tier'; | ||
|
|
||
| interface PComment { | ||
| data: { |
Contributor
There was a problem hiding this comment.
따로 타입을 만들면 좋을 것 같아요!
ex) TMiniProfile
Contributor
There was a problem hiding this comment.
그리고 data라는 속성명보다 좀 더 직관적인 속성명을 사용하면 더욱 직관적으로 코드를 이해할 수 있을 것 같아요 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📍 PR 타입 (하나 이상 선택)
❗️ 관련 이슈 [#]
📄 개요
🔁 변경 사항
📸 스크린샷
[기본 댓글]
[대댓글] - 2번째 스크린샷은 크기를 보기 편하게 캡처할 때만 bg를 임의적으로 바꾸었습니다.
👀 기타 더 이야기해볼 점