Fix Temporary File Cleanup#10
Merged
den-sq merged 2 commits intoChengLabResearch:mainfrom Apr 30, 2025
Merged
Conversation
…due to changes in the github permissions model. See - orgoro/coverage#259 - orgoro/coverage#281
- Addresses Backproject errors during pipeline due to permissions error. ChengLabResearch#9 - Now cleans out all memory maps to allow deletion of temporary files. - Also (silently, for now) leaves temporary files there if they can't be deleted. May figure out good approach to log that doesn't clog up the progress bar in future. This should allow the backproject pipeline to successfully write single files and MIPs, though I haven't tested that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #9 by updating the memmap cleanup, allowing the deletion of temporary files and enabling the progression of the backproject pipeline.