Addresses #6:#7
Merged
den-sq merged 6 commits intoChengLabResearch:mainfrom Apr 23, 2025
Merged
Conversation
- Specifying UTF-8 during JSON load allows the parser to handle line encodings. - More detailed error handling to make JSON laoding issues clearing. (done by @dvanselow)
Collaborator
Author
|
Hmm, should have run more tests. Will tweak to have the parser return the error object and handle the remaining areas. |
- Was failing tests with overflow. - Now converts to np.float64. - Also fixes calculate_chunk_size downstream.
- Updated tests for new string vals - Added a couple more checks for the error string in the server handler. - Fixed a error check for the slice visualization that would fail to catch failed json loads.
- Tests were failing with parameter error. - Now catch errors and return error strings like load_from_json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(done by @dvanselow)