fix: keep channel main session separate from project main#428
Merged
Conversation
📊 Coverage ReportTotal coverage: 47.8% (generated files excluded) Per-package breakdown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix channel/private main-session resolution so it only returns the agent-level main conversation, never a project-scoped main conversation.
Why
ResolveMainSessionis used by private/channel entrypoints such as Feishu when a resolved channel maps to a per-user private session. The previous lookup accepted any unarchivedkind = mainrow for the user and agent, including rows withproject_id IS NOT NULL. That could attach channel chats to project context by mistake.How
ProjectID == ""when selecting an existing main session insession.Registry.ResolveMain.isMainCandidate.Targeted test run:
Full
mise run formatwas attempted but hit existing/generated-web issues and a Vite+ stdout panic unrelated to this Go-only change.Refs
Fixes #427