Add types-colorama and drop mypy ignore for colorama#20940
Open
emlowe wants to merge 2 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Coverage Report for CI Build 26777713940Coverage decreased (-0.02%) to 91.479%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions30 previously-covered lines in 7 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
types-coloramato dev dependencies and updatepoetry.lock[mypy-colorama.*]ignore_missing_importsoverride frommypy.ini.templatecast(str, ...)indump_keyring.pynow that colorama constants are typedTest plan
./activated.py python manage-mypy.py build-mypy-ini && ./activated.py mypy(mypy 1.20.0, matchingmainlockfile)Note
Low Risk
Dev-only typing and a no-op runtime change to the keyring dump prompt string.
Overview
Adds
types-coloramato dev dependencies and refreshespoetry.lock, so mypy can type-checkcoloramawithout a blanket ignore.Removes the
[mypy-colorama.*]ignore_missing_importsentry frommypy.ini.template. Indump_keyring.py,get_passphrase_promptnow returns the styled string directly instead of wrapping it incast(str, ...), since colorama’s constants are typed as strings.Reviewed by Cursor Bugbot for commit 61b6559. Bugbot is set up for automated code reviews on this repo. Configure here.