Skip to content

Add types-colorama and drop mypy ignore for colorama#20940

Open
emlowe wants to merge 2 commits into
mainfrom
mypy-types-colorama
Open

Add types-colorama and drop mypy ignore for colorama#20940
emlowe wants to merge 2 commits into
mainfrom
mypy-types-colorama

Conversation

@emlowe
Copy link
Copy Markdown
Contributor

@emlowe emlowe commented May 26, 2026

Summary

  • Add types-colorama to dev dependencies and update poetry.lock
  • Remove the [mypy-colorama.*] ignore_missing_imports override from mypy.ini.template
  • Drop the redundant cast(str, ...) in dump_keyring.py now that colorama constants are typed

Test plan

  • ./activated.py python manage-mypy.py build-mypy-ini && ./activated.py mypy (mypy 1.20.0, matching main lockfile)

Note

Low Risk
Dev-only typing and a no-op runtime change to the keyring dump prompt string.

Overview
Adds types-colorama to dev dependencies and refreshes poetry.lock, so mypy can type-check colorama without a blanket ignore.

Removes the [mypy-colorama.*] ignore_missing_imports entry from mypy.ini.template. In dump_keyring.py, get_passphrase_prompt now returns the styled string directly instead of wrapping it in cast(str, ...), since colorama’s constants are typed as strings.

Reviewed by Cursor Bugbot for commit 61b6559. Bugbot is set up for automated code reviews on this repo. Configure here.

@emlowe emlowe requested a review from a team as a code owner May 26, 2026 17:10
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 26, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpypi/​types-colorama@​0.4.15.20260508100100100100100

View full report

@emlowe emlowe added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels May 26, 2026
@github-actions github-actions Bot added the merge_conflict Branch has conflicts that prevent merge to main label May 26, 2026
@github-actions github-actions Bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 1, 2026
@coveralls-official
Copy link
Copy Markdown

Coverage Report for CI Build 26777713940

Coverage decreased (-0.02%) to 91.479%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: 2 of 2 lines across 1 file are fully covered (100%).
  • 30 coverage regressions across 7 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

30 previously-covered lines in 7 files lost coverage.

File Lines Losing Coverage Coverage
chia/_tests/core/util/test_lockfile.py 21 77.42%
chia/full_node/full_node.py 4 88.1%
chia/full_node/full_node_api.py 1 88.56%
chia/seeder/dns_server.py 1 89.43%
chia/server/node_discovery.py 1 80.52%
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/wallet/wallet_node.py 1 87.36%

Coverage Stats

Coverage Status
Relevant Lines: 122263
Covered Lines: 112023
Line Coverage: 91.62%
Relevant Branches: 12062
Covered Branches: 10856
Branch Coverage: 90.0%
Branches in Coverage %: Yes
Coverage Strength: 1.83 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant