Skip to content

Add type checking - #60

Merged
emlowe merged 9 commits into
mainfrom
typing
Jun 2, 2026
Merged

emlowe merged 9 commits into
mainfrom
typing

Conversation

@richardkiss

Copy link
Copy Markdown
Contributor

No description provided.

@richardkiss
richardkiss force-pushed the typing branch 10 times, most recently from 2e4f679 to 3038a0f Compare August 16, 2025 21:06
@richardkiss
richardkiss requested a review from Copilot August 17, 2025 00:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds type checking support to the chiabip158 package by restructuring it as a proper Python package and providing type annotations.

  • Restructures the extension module to be properly packaged under chiabip158.chiabip158
  • Adds type stub file with annotations for the PyBIP158 class
  • Updates CI configuration to handle the new package structure during testing

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
setup.py Updates extension module name and adds package configuration with type stub inclusion
chiabip158/init.pyi Adds type annotations for the PyBIP158 class methods and constructor
chiabip158/init.py Creates package init file that imports PyBIP158 from the extension module
.github/workflows/build.yml Modifies CI test command to work around import conflicts with the new package structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread chiabip158/__init__.pyi Outdated
Comment thread chiabip158/__init__.pyi Outdated
@richardkiss
richardkiss requested review from altendky and emlowe August 18, 2025 19:11

@altendky altendky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread chiabip158/__init__.pyi Outdated
Comment thread chiabip158/__init__.py Outdated
Comment thread .github/workflows/build.yml
Comment thread setup.py
Comment thread setup.py
Comment thread chiabip158/__init__.pyi Outdated
Comment thread chiabip158/__init__.py Outdated
@emlowe

emlowe commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@BugBot review

@wjblanke wjblanke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@emlowe
emlowe merged commit 5fa14d6 into main Jun 2, 2026
44 checks passed
@emlowe
emlowe deleted the typing branch June 2, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants