Repository navigation
Conversation
richardkiss
force-pushed
the
typing
branch
10 times, most recently
from
August 16, 2025 21:06
2e4f679 to
3038a0f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds type checking support to the chiabip158 package by restructuring it as a proper Python package and providing type annotations.
- Restructures the extension module to be properly packaged under
chiabip158.chiabip158 - Adds type stub file with annotations for the PyBIP158 class
- Updates CI configuration to handle the new package structure during testing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.py | Updates extension module name and adds package configuration with type stub inclusion |
| chiabip158/init.pyi | Adds type annotations for the PyBIP158 class methods and constructor |
| chiabip158/init.py | Creates package init file that imports PyBIP158 from the extension module |
| .github/workflows/build.yml | Modifies CI test command to work around import conflicts with the new package structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
altendky
suggested changes
Aug 18, 2025
altendky
left a comment
Contributor
There was a problem hiding this comment.
- needs
chiabip158/py.typedadded and included in the sdist etc to export the hints - should run stubtest and mypy ( https://github.com/Chia-Network/chia_rs/blob/af0e3019369e5baf95af6cac41eff3fa3c185423/.github/workflows/benchmark.yml#L77-L95 is an example of stubtest usage) (both should be run across platforms and python versions)
altendky
reviewed
Aug 26, 2025
altendky
reviewed
Aug 26, 2025
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
emlowe
approved these changes
Jun 2, 2026
Contributor
|
@BugBot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.