Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.5.0", "pybind11>=2.10.0"]
requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.5.0", "pybind11>=3.1.0"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete pybind11 pin update

Medium Severity

The build-system requirement raises pybind11 to >=3.1.0, but setup_requires in setup.py still allows >=2.10.0. Depending on whether the build goes through PEP 517 or a legacy setup.py path, different major versions can be selected, so the intended floor bump is only half applied.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5967861. Configure here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python version metadata mismatch

Medium Severity

Requiring pybind11>=3.1.0 makes Python 3.9 the effective minimum for source builds, but python_requires remains >=3.7. On 3.7/3.8, installers accept the package then fail resolving build deps, because no pybind11 3.1+ supports those interpreters.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5967861. Configure here.

build-backend = "setuptools.build_meta"

[tool.setuptools_scm]
Expand Down
Loading