Repository navigation
Update pybind11 requirement from >=2.10.0 to >=3.1.0 #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [build-system] | ||
| requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.5.0", "pybind11>=2.10.0"] | ||
| requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.5.0", "pybind11>=3.1.0"] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Python version metadata mismatchMedium Severity Requiring Reviewed by Cursor Bugbot for commit 5967861. Configure here. |
||
| build-backend = "setuptools.build_meta" | ||
|
|
||
| [tool.setuptools_scm] | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete pybind11 pin update
Medium Severity
The build-system requirement raises
pybind11to>=3.1.0, butsetup_requiresinsetup.pystill allows>=2.10.0. Depending on whether the build goes through PEP 517 or a legacysetup.pypath, different major versions can be selected, so the intended floor bump is only half applied.Reviewed by Cursor Bugbot for commit 5967861. Configure here.