fix(transform): add test of scheduled transform with batch transform#7
Closed
ChihuaYing wants to merge 4 commits into
Closed
fix(transform): add test of scheduled transform with batch transform#7ChihuaYing wants to merge 4 commits into
ChihuaYing wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an integration regression test covering a scheduled transform pipeline that includes a batch python transform followed by a stream python transform, intended to prevent incorrect reuse of previous scheduled inputs.
Changes:
- Add a new scheduled transform YAML (
TransformScheduledBatchTransformBug.yaml) that chains SQL → batch python → stream python tasks. - Add a new
TransformITtest and a helper verifier to assert scheduled executions produce the expected aggregate result. - Modify the main PR test workflow to comment out a large set of CI jobs, leaving only
db-ceenabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
test/src/test/resources/transform/TransformScheduledBatchTransformBug.yaml |
New scheduled transform job definition reproducing the batch+scheduled scenario. |
test/src/test/java/cn/edu/tsinghua/iginx/integration/func/udf/TransformIT.java |
New integration test + helper to validate scheduled batch transform correctness. |
.github/workflows/tests.yml |
Disables (comments out) most CI jobs, significantly reducing PR validation coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+825
to
+828
| assertTrue(queryResult.getValues().size() >= 2); | ||
| for (List<Object> row : queryResult.getValues()) { | ||
| assertEquals(expectedSum, row.get(sumIndex)); | ||
| } |
Comment on lines
+447
to
+448
| Thread.sleep(5000L); // wait for the scheduled job to run at least twice | ||
| verifyScheduledBatchBugResult(33L); |
Comment on lines
+452
to
+455
| } catch (SessionException | InterruptedException e) { | ||
| LOGGER.error("Transform: execute fail. Caused by:", e); | ||
| fail(); | ||
| } |
Comment on lines
+13
to
+18
| jobs: | ||
| unit-test: | ||
| uses: ./.github/workflows/unit-test.yml | ||
| unit-mds: | ||
| uses: ./.github/workflows/unit-mds.yml | ||
| case-regression: | ||
| uses: ./.github/workflows/case-regression.yml | ||
| with: | ||
| metadata-matrix: '["zookeeper"]' | ||
| standalone-test: | ||
| uses: ./.github/workflows/standalone-test.yml | ||
| with: | ||
| metadata-matrix: '["zookeeper"]' | ||
| standalone-test-no-optimizer: | ||
| uses: ./.github/workflows/standalone-test-no-optimizer.yml | ||
| with: | ||
| metadata-matrix: '["zookeeper"]' | ||
| # unit-test: | ||
| # uses: ./.github/workflows/unit-test.yml | ||
| # unit-mds: | ||
| # uses: ./.github/workflows/unit-mds.yml | ||
| # case-regression: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.