Repository navigation
Remove the in-game Dear ImGui Mod Menu - #39
Merged
Merged
Conversation
…pack theme The in-game Mod Menu is drawn by Dear ImGui on the game's own GL context through the present hook. CaramelTheme/CaramelWidgets from the Caramel UI pack are ported into pl/menu as MenuTheme/MenuWidgets, so the launcher and the in-game menu share one design language. Adds the two present-frame effects (frame generation, motion blur) on the eglSwapBuffers detour: both blend the previous presented frame into the new one, neither presents an extra frame, and the blur budget is clamped.
The in-game Mod Menu UI is deleted; the mod systems it fronted stay. - drop src/pl/menu/* (MenuHost/Render/Filter/Theme/Widgets/Jni) and the pl::menu::Frame call in PresentFrameEffect::OnPresentBoundary - drop the vendored third_party/imgui/ and its NOTICE attribution - drop the imgui CMake target and the sweetloader link - drop MenuFilterTest and its run_tests.sh entry
Lynxifyy
marked this pull request as ready for review
November 14, 2026 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Removes the in-game Dear ImGui Mod Menu from the native library. The mod systems it fronted stay; only the menu UI goes.
Companion to ChimeraAnt-DEV/CaramelClient#184, which bumps this submodule and drops the Java-side wiring.
Removed
src/pl/menu/—MenuHost,MenuRender,MenuFilter,MenuTheme,MenuWidgets,MenuJni(+ headers)pl::menu::Frame(...)call inPresentFrameEffect::OnPresentBoundary— the menu was the first thing the present boundary drew, before the present-frame effectsthird_party/imgui/(vendored Dear ImGui 1.91.5 + the GLES3 backend), whose only consumer was the menuimguiCMake target, itstarget_link_libraries(sweetloader … imgui)entry, and theNOTICEattribution blocktests/cosmetics/MenuFilterTest.cppand itsrun_tests.shentryKept
pl::render,pl::hooks,pl::runtime,pl::memoryand the rest of the library are untouched.Verification
bash tests/cosmetics/run_tests.sh— all host tests passscripts/check_sources_listed.py— sources, tests and the build list agreescripts/check_pinned_deps.py— every fetched dependency is pinned by commit and attributed inNOTICE