Skip to content

feat: add prisma generate and tsconfig to migration image for seed support - #40

Merged
Cho-Geer merged 1 commit into
developfrom
feat/migrate-image-seed
Sep 22, 2026
Merged

Cho-Geer merged 1 commit into
developfrom
feat/migrate-image-seed

Conversation

@Cho-Geer

Copy link
Copy Markdown
Owner

Summary

  • migration イメージに COPY tsconfig.json と RUN npm run prisma:generate を追加(Dockerfile.migrate +4 行)
  • 現状は npm ci が COPY prisma より先に走り generate が一度も実行されないため、@prisma/client が throw スタブのまま → prisma:seed が必ず失敗する
  • tsconfig.json 未同梱のため ts-node がデフォルトのコンパイラオプションで型チェックし失敗する問題も同時に解消

Why

  • booking-deploy の dev 適用手順(Step 5)で seed を実行する前提修正
  • 既存 CI が green ののは prisma migrate deploy(CLI のみ)しか実行していないため。seed を試すまで表面化しない欠陥

Test plan

  • ローカル verify: verify-images.sh dev 通し実行済み(pull → 依存起動 → migration 12 件適用 → backend/frontend healthy)
  • マージ後: CI で migration イメージが push されること(develop / develop-<sha> タグ)
  • マージ後: docker compose run --rm migration npm run prisma:seed が成功すること

…pport

- COPY tsconfig.json so ts-node uses proper compiler options for seed.ts
- RUN prisma:generate so @prisma/client is no longer a throw stub
  (npm ci runs before COPY prisma, so postinstall generate found no schema)
- unblocks: docker compose run migration npm run prisma:seed (dev-adoption plan Step 5)
@Cho-Geer
Cho-Geer merged commit 68d708e into develop Sep 22, 2026
3 checks passed
@Cho-Geer
Cho-Geer deleted the feat/migrate-image-seed branch October 4, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants