Parameters for topo fill coefficients changed to be modifiable#167
Open
djmallum wants to merge 1 commit into
Open
Parameters for topo fill coefficients changed to be modifiable#167djmallum wants to merge 1 commit into
djmallum wants to merge 1 commit into
Conversation
a1 and b2 are modified in the if-else statement but they are redeclared, shadowing the original declarations before the if-else. This means that a1 and b2 never actually depend on snow-depth when they are used after the if-else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a1 and b2 are modified in the if-else statement but they are redeclared, shadowing the original declarations before the if-else. This means that a1 and b2 never actually depend on snow-depth when they are used after the if-else. No idea how often the subgrid topography is used or even this version.
Just happened to notice it while downloading how it works into my brain.