Repository navigation
Fix v1 migration on Windows: close the old file before replacing it - #9
Merged
Merged
Conversation
migrateV1ToV2 kept the old data file open until it returned, so the rename that installs the migrated file over it failed on Windows with "Access is denied" and a version 1 database could not be opened there. Close it before the install step. TestV1DatabaseMigratesToV2 fails on windows-latest without this.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainfailsEngine Tests (windows-latest)since #8 (run):migrateV1ToV2held the old data file open (defer src.disk.Close()) until it returned, so the rename that installs the migrated file over it failed: Windows refuses to replace an open file, while macOS and Linux allow it. In practice a version 1 database could not be opened on Windows. Nothing was damaged: the failure happens before any file is replaced, and the next start retries.The fix closes the old file before the install step. The v0 migration already did this, and the WAL files are closed before they are moved.
Testing
go build ./... && go vet ./... && go test ./... -racepass on macOS.TestV1DatabaseMigratesToV2, which fails onwindows-latestwithout this change; this PR's Windows job is the check.