Repository navigation
Reject non-localhost Host headers on the DevTools JSON endpoint - #42
Merged
Merged
Conversation
On Vite 5.x and 6.x, the synchronous body of plugin configureServer hooks executes before Vite registers hostCheckMiddleware (CVE-2025-24010). Because our endpoint middleware is registered in the synchronous body of configureServer (and cannot be moved to a post-hook without being intercepted by Vite's htmlFallbackMiddleware in SPA mode), validate the Host header directly against localhost (localhost, *.localhost, 127.0.0.0/8, [::1]) and reject non-localhost requests with HTTP 403 to prevent DNS rebinding attacks from reading the workspace root path and UUID. TAG=agy CONV=7701f19a-25ab-49bf-9131-831a137a7977
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Vite 5.x and 6.x, the synchronous body of plugin configureServer hooks executes before Vite registers hostCheckMiddleware (CVE-2025-24010). Because our endpoint middleware is registered in the synchronous body of configureServer (and cannot be moved to a post-hook without being intercepted by Vite's htmlFallbackMiddleware in SPA mode), validate the Host header directly against localhost (localhost, *.localhost, 127.0.0.0/8, [::1]) and reject non-localhost requests with HTTP 403 to prevent DNS rebinding attacks from reading the workspace root path and UUID.
TAG=agy
CONV=7701f19a-25ab-49bf-9131-831a137a7977