Put persona and accent into the base conversation prompts

[Borisserz]

Summary

• Addresses Ensure accent is included in the base prompt #32 (prompt half)
• Voice and typed-reply system prompts now include an explicit Persona and accent line using each module’s variety plus existing speechGuidance
• iOS and Android TeachingPolicy stay in lockstep (check_cross_platform.py prompts check)

Note: Kore / Aoede are Gemini Live voice presets. This app currently uses OpenAI gpt-live-1 with voice marin. Voice-preset experimentation fits better with #30 (Gemini). This PR covers the prompt half of #32 without changing the audio voice, so it does not fully close #32.

Test plan

• swift test --package-path apps/ios --filter 'AdditionalLanguageTests|LanguageTests'
• python3 scripts/check_cross_platform.py
• Manual live conversation in Spanish / Mandarin and listen for consistent regional persona

Summary by CodeRabbit

• Improvements
  • Voice responses now more consistently reflect the selected language variety, speaker persona, and accent.
  • Typed replies now maintain the selected language variety and accent for a more consistent learning experience.
  • Speaking guidance is better aligned with the configured language and persona.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8b111ec4-fdc8-4994-b35e-f8596b37cce1

📥 Commits

Reviewing files that changed from the base of the PR and between df6021a and f48c7ea.

📒 Files selected for processing (3)

• apps/android/app/src/main/java/chat/mural/core/TeachingPolicy.kt
• apps/ios/Core/TeachingPolicy.swift
• apps/ios/Tests/AdditionalLanguageTests.swift

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

---

📝 Walkthrough

Walkthrough

Voice and typed-response prompts now preserve language variety, persona, and accent guidance on Android and iOS. An iOS test verifies the added voice prompt details.

Changes

Language guidance

Layer / File(s)	Summary
Prompt guidance updates apps/android/app/src/main/java/chat/mural/core/TeachingPolicy.kt, apps/ios/Core/TeachingPolicy.swift, apps/ios/Tests/AdditionalLanguageTests.swift	Voice and typed-response instructions now include language variety, persona, and accent guidance. Existing response constraints remain. The iOS test checks the persona/accent label and configured variety.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: chuloo

Merge Risk: ⚪ Minimal · up to f48c7

The prompt updates have no established correctness, availability, or data-integrity risk.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	Issue #32 requires persona and accent in the base system instructions and requests voice-preset experimentation with Kore and Aoede. The iOS and Android TeachingPolicy prompts now include language v…	Implement and test the voice-preset experimentation requested by issue #32, or update the issue to track that requirement separately before marking the linked issue complete.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding persona and accent information to the base conversation prompts.
Description check	✅ Passed	The description explains the prompt changes, scope, verification steps, cross-platform synchronization, and the remaining limitation that manual live testing is pending. It does not explicitly address…
Out of Scope Changes check	✅ Passed	The changes update iOS and Android TeachingPolicy prompts and add a related iOS prompt test. These changes support the persona and accent objective in issue #32. No unrelated change is identified.

Full details: Linked Issues check

Explanation

Issue #32 requires persona and accent in the base system instructions and requests voice-preset experimentation with Kore and Aoede. The iOS and Android TeachingPolicy prompts now include language variety, persona, accent, and related guidance. The iOS test checks the persona-and-accent prompt content, and the cross-platform prompt check is reported. The PR does not change or test voice presets; it keeps the marin voice. This leaves the voice-preset requirement unmet.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}