refactor: interp2d now uses grid_sample where possible#375
Open
ConnorStoneAstro wants to merge 4 commits intodevfrom
Open
refactor: interp2d now uses grid_sample where possible#375ConnorStoneAstro wants to merge 4 commits intodevfrom
ConnorStoneAstro wants to merge 4 commits intodevfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #375 +/- ##
==========================================
- Coverage 93.76% 92.28% -1.48%
==========================================
Files 57 57
Lines 2599 2619 +20
==========================================
- Hits 2437 2417 -20
- Misses 162 202 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Rouzib <npayot@gmail.com>
rouzib
approved these changes
Jun 12, 2025
Collaborator
rouzib
left a comment
There was a problem hiding this comment.
I went throught my own tests comparing the output of the changed functions as well as their gradient. All my tests remain consistent between the current main branch and the new fast interp2d.
Should we expose the interpolation mode in the lenses to the user? If so, we could add the bicubic mode as an option.
Changes:
- Removed "extrapolate" and "clamp" as a padding_mode option since "extrapolate" is not supported by the old_interp2d and "clamp" is not supported by grid_sample.
- Updated
interp2ddocumentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.