fix(security): audit remediation - path traversal, wiki unification, dead code, complexity - #47
Merged
Merged
Conversation
added 2 commits
July 4, 2026 04:55
…reduce complexity Security: - Add shared/path_safety.py with safe_resolve() for path traversal prevention - Add path validation to FileWiki (now WikiManager) update/get/delete - Add path validation to backup.py and backup_cron.py restore - Add path validation to import_export.py import_user - All 8 SQL injection findings are false positives (standard SQLite pattern) Wiki unification: - Create wiki/manager.py WikiManager with layer-based separation (user/agent/shared) - Remove wiki/file_wiki.py, wiki/user_wiki.py, wiki/agent_wiki.py (~900 lines duplication) - Update all imports in server.py, dashboard.py, backup_cron.py, tests Dead code wiring: - Wire saga_crypto.read_state_legacy_or_encrypted into saga.py and backup_cron.py Complexity reduction: - Extract _compensate_inner_saga and _compensate_step from saga._compensate - Extract 5 helper methods from emotion_trigger.should_save Tests: 372 passed (was 338, +34 new)
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security
Tests
Files