fix(hooks): wire all 24 hooks, start schedulers, fix threading, add validation - #49
Merged
Merged
Conversation
…ding, add validation Critical (AUDIT_BUGS #1-3): - Add _fire_hook safe wrapper to tools_layer.py - Wire fire() into memory_remember (importance_gate, emotion_trigger, message_received, agent hooks) - Wire fire() into memory_recall and memory_episode_recall (retrieval_router, auto_context) - Wire fire() into memory_episode_save (emotion_trigger, state_delta, consolidation) - Wire fire() into session_start/end and graph_add/query - Replace direct emotion_trigger.should_save() with fire() + fallback Important (AUDIT_BUGS #4-8): - Start importance_scheduler in lifespan with graceful shutdown - Add periodic forgetting.cleanup() and consolidation.consolidate_staging() tasks - Replace threading.Lock with ThreadPoolExecutor(max_workers=1) in hooks/shared.py - Add _validate_layer() to all 17 MCP tool functions - Wire context_inject through auto_context hook 21 _fire_hook calls across tools_layer.py
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…, triggered via hooks)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUDIT_BUGS.md Fixes (10/11 items)
Critical (#1-3): Hook wiring
Important (#4-8): Schedulers & threading
Skipped
Verification