Main

.github/CODEOWNERS

@@ -6,7 +6,7 @@
 # @global-owner1 and @global-owner2 will be requested for
 # review when someone opens a pull request.
 #*       @global-owner1 @global-owner2
-* @rehaddad @ashp @ios-xr/sl-api-dev-team
+* @hshahul @smaini @gsubbann @xr/sl-api-dev
 
 # Order is important; the last matching pattern takes the most
 # precedence. When someone opens a pull request that only

.github/workflows/proto-ci.yml

@@ -0,0 +1,100 @@
+name: Proto CI
+
+on:
+  pull_request:
+    branches:
+      - main
+    types:
+      - opened
+      - synchronize
+      - reopened
+      - ready_for_review
+  push:
+    branches:
+      - main
+  merge_group:
+    types:
+      - checks_requested
+
+permissions:
+  contents: read
+
+concurrency:
+  group: proto-ci-${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  proto-lint:
+    name: proto-lint
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+
+      - name: Run Buf lint
+        uses: bufbuild/buf-action@v1
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          pr_comment: false
+          lint: true
+          breaking: false
+          format: false
+          push: false
+          archive: false
+
+  proto-breaking:
+    name: proto-breaking
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+
+      - name: Run Buf breaking check
+        uses: bufbuild/buf-action@v1
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          pr_comment: false
+          lint: false
+          breaking: true
+          format: false
+          push: false
+          archive: false
+
+  generated-bindings-up-to-date:
+    name: generated-bindings-up-to-date
+    runs-on: ubuntu-latest
+    timeout-minutes: 45
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+
+      - name: Regenerate bindings in Docker
+        shell: bash
+        run: |
+          set -euo pipefail
+          make clean
+          make bindings
+
+      - name: Verify generated bindings are committed
+        shell: bash
+        run: |
+          set -euo pipefail
+
+          git diff --exit-code
+
+          if [[ -n "$(git status --porcelain)" ]]; then
+            echo "::error::Generated bindings are not up to date. Run 'make clean && make bindings' locally and commit the result."
+            git status --short
+            exit 1
+          fi

BUILD.bazel

@@ -0,0 +1,21 @@
+# Copyright (c) 2025 by Cisco Systems, Inc.
+# All rights reserved.
+
+"""
+Service Layer Object Model - Root BUILD file
+
+This module provides pre-generated protobuf bindings for IOS-XR Service Layer API.
+
+The actual bindings are exported from subdirectories:
+- grpc/go/src/gengo/BUILD.bazel - Go protobuf bindings
+- grpc/python/src/genpy/BUILD.bazel - Python protobuf bindings
+
+Source: https://gh-xr.scm.engit.cisco.com/xr/service-layer-objmodel
+"""
+
+# Empty exports - actual targets are in subdirectories
+exports_files(
+    ["MODULE.bazel"],
+    visibility = ["//visibility:public"],
+)
+

Dockerfile

@@ -17,18 +17,25 @@ RUN . /opt/venv/bin/activate
 COPY grpc/python/requirements.txt /tmp
 RUN pip3 install -r /tmp/requirements.txt
 
-ARG GO_VER=1.19
+ARG GO_VER=1.24.3
 ARG WS=/ws
 RUN mkdir -p ${WS}
 WORKDIR ${WS}
-ARG PROTOC_VER=3.18.3
+ARG PROTOC_VER=32.0
 
 # Install GO binary https://go.dev/doc/install
 RUN wget -qO- https://golang.org/dl/go${GO_VER}.linux-amd64.tar.gz | tar xzvf - -C /usr/local
 
 #Ensure PATH has GO binary path
 ENV PATH="${PATH}:/usr/local/go/bin"
 
+# Allow callers to override Go module proxy and checksum settings, while
+# providing sane defaults for public environments.
+ARG GOPROXY=https://proxy.golang.org,direct
+ARG GOSUMDB=sum.golang.org
+ENV GOPROXY="${GOPROXY}"
+ENV GOSUMDB="${GOSUMDB}"
+
 # Avoid timezone prompts
 ENV DEBIAN_FRONTEND=noninteractive
 
@@ -49,8 +56,8 @@ RUN unzip protoc-${PROTOC_VER}-linux-x86_64.zip -d /usr/local
 # Install protoc-gen-go and protoc-gen-go-grpc
 # Reference https://grpc.io/docs/languages/go/quickstart
 
-RUN go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.28
-RUN go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.2
+RUN go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.36.7
+RUN go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.5.1
 
 # Above were installed in $HOME/go, since this is running as root
 ENV PATH="${PATH}:/root/go/bin"

MODULE.bazel

@@ -0,0 +1,21 @@
+"""
+Service Layer Object Model - Generated protobuf bindings for IOS-XR Service Layer API
+
+This module provides pre-generated bindings:
+- Go protobuf bindings (grpc/go/src/gengo/)  
+- Python protobuf bindings (grpc/python/src/genpy/)
+
+Note: 
+- Proto files are NOT compiled by this module
+- Bindings are pre-generated and committed (via 'make bindings')
+- Exported as filegroups - XR shell component wraps them in proper libraries
+
+Source: https://gh-xr.scm.engit.cisco.com/xr/service-layer-objmodel
+"""
+
+module(
+    name = "service_layer_objmodel",
+    version = "0.11.0-iosxr.0",
+)
+
+# No Bazel dependencies needed - only exports filegroups

Makefile

@@ -1,62 +1,67 @@
-SHELL = /bin/bash
-USER := $(shell id -un)
+SHELL := /bin/bash
+
 PWD := $(shell pwd)
 
-IMAGE_NAME = slapi
-IMAGE_TAG = latest
-CONTAINER_NAME = slapi-container
+IMAGE_NAME ?= slapi
+IMAGE_TAG ?= latest
+CONTAINER_NAME ?= slapi-container
+
+DOCKER_VOLUME ?= $(PWD):/slapi
+DOCKER_WORKDIR ?= /slapi
+
+DOCKER_BUILD := docker build -t $(IMAGE_NAME):$(IMAGE_TAG) .
 
-DOCKER_BUILD = docker build -t $(IMAGE_NAME) .
+DOCKER_ENV := \
+	-e "http_proxy=$(http_proxy)" \
+	-e "https_proxy=$(https_proxy)" \
+	-e "HTTP_PROXY=$(HTTP_PROXY)" \
+	-e "HTTPS_PROXY=$(HTTPS_PROXY)" \
+	-e "no_proxy=$(no_proxy)" \
+	-e "NO_PROXY=$(NO_PROXY)"
 
-ifeq ($(DOCKER_VOLUME),)
-override DOCKER_VOLUME := "$(PWD):/slapi"
-endif
+DOCKER_RUN := docker run --name $(CONTAINER_NAME) --rm \
+	-v "$(DOCKER_VOLUME)" \
+	-w "$(DOCKER_WORKDIR)" \
+	$(DOCKER_ENV)
 
-ifeq ($(DOCKER_WORKDIR),)
-override DOCKER_WORKDIR := "/slapi"
-endif
+DOCKER_RUN_TTY := docker run --name $(CONTAINER_NAME) --rm \
+	-v "$(DOCKER_VOLUME)" \
+	-w "$(DOCKER_WORKDIR)" \
+	$(DOCKER_ENV) \
+	-it
 
-DOCKER_RUN := docker run --name $(CONTAINER_NAME) --rm=true --privileged \
-    -v $(DOCKER_VOLUME) \
-    -w $(DOCKER_WORKDIR) \
-    -e "http_proxy=$(http_proxy)" \
-    -e "https_proxy=$(https_proxy)" \
-    -i$(if $(TERM),t,)
+.PHONY: clean build bindings tutorial cpp-tutorial xr-docs dotnet-docs slapi-bash
+.DEFAULT_GOAL := slapi-bash
 
-# New clean target to remove the container and image
 clean:
 	-docker rm -f $(CONTAINER_NAME)
 	-docker rmi -f $(IMAGE_NAME):$(IMAGE_TAG)
 
-.PHONY: slapi-bash
-.DEFAULT_GOAL := slapi-bash
-
 build:
-	$(DOCKER_BUILD) ;
+	$(DOCKER_BUILD)
+
+bindings: build
+	$(DOCKER_RUN) $(IMAGE_NAME):$(IMAGE_TAG) \
+		bash -c "cd grpc/utils && ./gen-all.sh"
 
 tutorial: build bindings
-	$(DOCKER_RUN) -t $(IMAGE_NAME):$(IMAGE_TAG) \
-	make -C grpc/go/src/tutorial
+	$(DOCKER_RUN) $(IMAGE_NAME):$(IMAGE_TAG) \
+		make -C grpc/go/src/tutorial
 
 cpp-tutorial: build bindings
-	$(DOCKER_RUN) -t $(IMAGE_NAME):$(IMAGE_TAG) \
-	bash -c "make -C grpc/cpp/src all && \
-			make -C grpc/cpp/src install && \
-			make -C grpc/cpp/src/tutorial && \
-			make -C grpc/cpp/src/tutorial/rshuttle"
-
-bindings: build
-	$(DOCKER_RUN) -t $(IMAGE_NAME):$(IMAGE_TAG) \
-	bash -c "cd grpc/utils && ./gen-all.sh"
+	$(DOCKER_RUN) $(IMAGE_NAME):$(IMAGE_TAG) \
+		bash -c "make -C grpc/cpp/src all && \
+		         make -C grpc/cpp/src install && \
+		         make -C grpc/cpp/src/tutorial && \
+		         make -C grpc/cpp/src/tutorial/rshuttle"
 
 xr-docs: build
-	$(DOCKER_RUN) -t $(IMAGE_NAME):$(IMAGE_TAG) \
-	bash -c "cd grpc/xrdocs/scripts && ./doc-gen.sh"
+	$(DOCKER_RUN) $(IMAGE_NAME):$(IMAGE_TAG) \
+		bash -c "cd grpc/xrdocs/scripts && ./doc-gen.sh"
 
 dotnet-docs: build
-	$(DOCKER_RUN) -t $(IMAGE_NAME):$(IMAGE_TAG) \
-	bash -c "cd grpc/dotnet/ && doxygen ./doxyfile"
+	$(DOCKER_RUN) $(IMAGE_NAME):$(IMAGE_TAG) \
+		bash -c "cd grpc/dotnet && doxygen ./doxyfile"
 
 slapi-bash: build
-	$(DOCKER_RUN) -t $(IMAGE_NAME):$(IMAGE_TAG) bash
-
+	$(DOCKER_RUN_TTY) $(IMAGE_NAME):$(IMAGE_TAG) bash

README.md

@@ -94,6 +94,19 @@ grpc/python/src/genpy
 grpc/cpp/src/gencpp
 grpc/dotnet/src/gencs
 ```
+### Go Module Identity
+
+The generated Go bindings under `grpc/go/src/gengo` are intended to behave as a
+normal Go module. The module path is:
+
+```
+github.com/Cisco-Service-Layer/service-layer-objmodel/grpc/go/src/gengo
+```
+
+This allows the generated bindings to participate more cleanly in TPS and
+future XR Go dependency workflows. The generated package name remains
+`service_layer`.
+
 The bindings can also be generated manually using protoc in an environment with the correct toolchain versions. The toolchain versions in the Dockerfile:
 * GO_VER: Go version
 * GRPC_VER: gRPC version
@@ -200,3 +213,10 @@ This will generate html documentation in grpc/dotnet/docs/html/
 
 We hope that the above was useful quick overview about the Service Layer API. We recommend that the reader go over the Python quick tutorial first and then go over the .proto files under grpc/protos (or look at the generated .html pages - these are not kept in this repo, but can be auto-generated from this repo).
 
+## Notes
+
+In proto3, if the message field is implicit, and it is set to its default value, proto3 will not serialize this field and it will be omitted from the message payload. This is standard behavior due to the proto3 serialization rules and does not require any special handling in client applications. For more information, see the official documentation: <https://protobuf.dev/programming-guides/proto3/>
+
+For example, in the context of `SLAFGetMsgRsp` [grpc/protos/sl_af.proto](grpc/protos/sl_af.proto), if the `ClientID` field is set to 0, the `ClientID` field will not appear in the serialized response message. For any other client ID value, the field will be included in the response.
+
+Please note, this is a feature of the underlying technology (gRPC/proto3) and not specific to the SL-API. This note is included for clarity.