VPC Pair 4.x Implementation#197
VPC Pair 4.x Implementation#197sivakasi-cisco wants to merge 64 commits intoCiscoDevNet:nd42_integrationfrom
Conversation
|
Continuation of sivakasi-cisco#1 |
This reverts commit 565a069.
This reverts commit e14537f.
…sible-nd into vpc_pair_4x_nd # Conflicts: # plugins/models/model_playbook_vpc_pair.py # plugins/module_utils/endpoints/v1/manage_vpc_pair/model_playbook_vpc_pair.py # plugins/module_utils/manage/vpc_pair/model_playbook_vpc_pair.py
…sible-nd into vpc_pair_4x_nd
1. Fix deploy timeout in merge\ 2. Check modules gathered output for ebgp vpc pair list 3. Remove delete in bulk as its not required for vpc\ 4. cleanups from the review comments expected 5. Fine tuning IT
…se by default and Correcting the IT accordingly
allenrobel
left a comment
allenrobel
left a comment
There was a problem hiding this comment.
Approving with comments. Also, there's some common functionality (fabric switch inventory, etc) that we need to discuss moving into a common set of classes/methods. For example, my PR (not yet submitted) includes a FabricContext class that provides information similar to fabric switch inventory. Though, I realize that we are under deadline and that things like this will necessarily have to wait for a future consolidation phase.
plugins/module_utils/endpoints/v1/manage/manage_fabrics_actions_config_save.py
Outdated
Show resolved
Hide resolved
|
Still quite a few ansible-sanity test failures. Make sure to run the following commands from the root of your repo and fix any failures |
Thank you so much for your review and comments, Allen. I find your comments helpful and had addressed them. Shall do a round of testing and push the diffs. I shall try moving/consolidating the shared common logic as well and also will add more inputs if we get some discussion on it too. |
- resuse existing mixins without more duplicates\ - Adding type annotations to method signatures - revisited the required imports and removed others
Addressed |
|
Revisiting the integ test for each fabric |
| - Only applies to deleted state. | ||
| type: bool | ||
| default: false | ||
| verify_option: |
There was a problem hiding this comment.
Collapse verify_option and suppress_verification into the following structure
verify:
enabled: true
retries: 5
timeout: 10
| - Name of the fabric. | ||
| required: true | ||
| type: str | ||
| deploy: |
There was a problem hiding this comment.
We need to support separate save and deploy options
Use the following property structures
config_actions:
save: true
deploy: true
type: switch [Enum Choices: switch and global]If config_actions.save is false and config_actions.deploy is true we should fail
3 participants
vPC Pair support for ND 4.x
nd_manage_vpc_pair can create, update, delete, override, and gather vPC pairs.
The big module logic was split into focused helper files (query, validation, actions, deploy, etc.)
We added dedicated vPC Pair endpoints/models/schemas and connected them through the orchestrator + state machine flow.
Integration tests were added across all main scenarios (merge/replace/override/delete/gather).