Ansible ND 4.X Fabric Modules for iBGP, eBGP and External Fabric Types#209
Merged
mtarking merged 29 commits intoCiscoDevNet:nd42_integrationfrom Apr 8, 2026
Merged
Conversation
mikewiebe
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
mikewiebe
changed the title
gmicol
requested changes
Apr 1, 2026
mikewiebe
changed the title
mikewiebe
changed the title
allenrobel
approved these changes
Apr 2, 2026
Collaborator
allenrobel
left a comment
allenrobel
left a comment
There was a problem hiding this comment.
Approving with comments.
mikewiebe
commented
Apr 6, 2026
mtarking
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces 3 new modules to configure ibgp, ebgp and external fabric types.
Additionally this has a fix for state: merged when using the orchestrartor and ND state machine
Fix Details:
Fix:
state: mergedoverwrites unspecified fields with Pydantic defaultsRoot Cause
When
state: mergedis used and a field likebanneris not specified in the task config, Pydantic still populates it with its default value (""). Themerge()method inNDBaseModelwas applying all non-None field values from the proposed config — including these unintended defaults — overwriting existing values.