Skip to content

Add support for waxed varients for CopperRail simple admin hack#926

Open
bulbm1n wants to merge 3 commits into
CivMC:mainfrom
bulbm1n:main
Open

Add support for waxed varients for CopperRail simple admin hack#926
bulbm1n wants to merge 3 commits into
CivMC:mainfrom
bulbm1n:main

Conversation

@bulbm1n
Copy link
Copy Markdown

@bulbm1n bulbm1n commented May 25, 2026

https://discord.com/channels/912074050086502470/1508545613782843642

Per my own suggestion, pretty simple implementation that treats it as a regular copper block then turns it back to a waxed copper block after it runs the checks and needs to replace the block. Felt that was the easiest way.

Copy link
Copy Markdown
Contributor

@okx-code okx-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to encode the oxidation steps like this you might as well remove all NMS usage related to the oxidation. Code can be cleaned up significantly.

@bulbm1n
Copy link
Copy Markdown
Author

bulbm1n commented May 26, 2026

I left it using the current system so I didn't have to re-implement WeatheringCopper.getChanceModifier(). I can rewrite it though. I only read your original response from the notif, not your edited one, much easier fix.

@bulbm1n
Copy link
Copy Markdown
Author

bulbm1n commented May 26, 2026

Let me know how that is, I rewrote a lot of it. More self-contained

Copy link
Copy Markdown
Contributor

@okx-code okx-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the axe damaging semantics so that it is no longer damaged for each oxidation step. also not sure why you removed the comment for the blockformevent listener?

private enum CopperStage {
UNAFFECTED(Material.COPPER_BLOCK, Material.WAXED_COPPER_BLOCK, 1.0f),
EXPOSED(Material.EXPOSED_COPPER, Material.WAXED_EXPOSED_COPPER, 1.0f),
WEATHERED(Material.WEATHERED_COPPER, Material.WAXED_WEATHERED_COPPER, 0.75f),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this is the wrong way round, it's only unaffected blocks that have a 75% chance

@okx-code
Copy link
Copy Markdown
Contributor

Looks better overall though

@bulbm1n
Copy link
Copy Markdown
Author

bulbm1n commented May 28, 2026

Fixed all of the above. Got confused with the comment and the durability because I repeatedly had to pick this up and put it down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants