Fix AirDatepicker crash when locale is not in airdatePickrLocales#206
Open
bamsejon wants to merge 1 commit intoClaperCo:devfrom
Open
Fix AirDatepicker crash when locale is not in airdatePickrLocales#206bamsejon wants to merge 1 commit intoClaperCo:devfrom
bamsejon wants to merge 1 commit intoClaperCo:devfrom
Conversation
The issue occurs when: 1. LANGUAGES env var includes locales not imported in app.js (e.g., "sv") 2. window.claperConfig.supportedLocales contains these locales 3. The fallback check only verified against supportedLocales, not actual imports 4. This caused airdatePickrLocales[locale] to return undefined 5. AirDatepicker's _handleLocale crashed trying to parse undefined Fix: - Added more locale imports from air-datepicker (sv, da, nb, fi, pl, pt, ru, uk, cs, ja, zh, ko) - Added corresponding moment locale imports - Changed fallback check to verify locale exists in airdatePickrLocales keys Fixes the "Create" button being disabled on the /events/new page.
Contributor
|
Thanks for your report and contribution, I'll test that asap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/events/newpage when LANGUAGES env var contains locales not imported from air-datepickerProblem
When the
LANGUAGESenvironment variable includes locales that weren't imported fromair-datepicker(like Swedish "sv"), the datepicker initialization crashes with"undefined" is not valid JSON. This prevents the Create button from being enabled on the event creation page.Fixes #205
Changes
Added locale imports (
assets/js/app.js):Fixed fallback logic:
airdatePickrSupportedLocales(which came from config)airdatePickrLocaleskeysairdatePickrLocalesdefinition before the fallback checkTest plan
LANGUAGES=en,svand verify/events/newpage works🤖 Generated with Claude Code