fix: deterministic skill order in the available_skills manifest - #214
Closed
Classic298 wants to merge 1 commit into
Closed
fix: deterministic skill order in the available_skills manifest#214Classic298 wants to merge 1 commit into
Classic298 wants to merge 1 commit into
Conversation
skill_ids is a set union and set iteration order varies across worker processes (string hash randomization), so on multi-worker or multi-replica installs the <available_skills> block in the system prompt shuffles between requests. That changes the system prompt bytes every turn and silently breaks provider prompt caching for the entire prefix (system prompt, tool definitions and history), so every request pays a full cache write and never gets a cache read. Sort the ids before building the manifest so the prompt is byte-stable across turns and replicas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skill_ids is a set union and set iteration order varies across worker processes (string hash randomization), so on multi-worker or multi-replica installs the <available_skills> block in the system prompt shuffles between requests. That changes the system prompt bytes every turn and silently breaks provider prompt caching for the entire prefix (system prompt, tool definitions and history), so every request pays a full cache write and never gets a cache read. Sort the ids before building the manifest so the prompt is byte-stable across turns and replicas.
Contributor License Agreement
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.