Add sensitivity slider for mouse emulation with controller#529
Open
mevouc wants to merge 4 commits intoClassicOldSong:moonlight-noirfrom
Open
Add sensitivity slider for mouse emulation with controller#529mevouc wants to merge 4 commits intoClassicOldSong:moonlight-noirfrom
mevouc wants to merge 4 commits intoClassicOldSong:moonlight-noirfrom
Conversation
Owner
|
Thank you very much for the PR, but the locale part I prefer only adding English and parts you're sure about. Translations should use a separate pass since lots of other languages are already missing loads of translations. |
This reverts most languages from commit 2cee67e.
Author
|
Alright, I understand I was unsure about that part anyway. Thanks for the feedback. I've added a commit to remove all languages except English and French. |
Author
|
Hi @ClassicOldSong. Were you able to take a new look at this? |
Owner
|
Definitely, being busy recently, will take a look soon! |
Author
|
No problem. I don't want to spam you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Screenshots
Settings when "Mouse emulation via gamepad" is checked:

Settings when "Mouse emulation via gamepad" is un-checked:

Slider + default value:

Slider + minimal value:

Slider + max value:

Menu view with a phone + French:

Slider view with a phone + French:

Not impacted but related
Pressing X
There was an existing feature to "control" the speed of the cursor when using mouse emulation, by pressing button X.
This feature remains untouched, because it's very buggy and not reliable:
I'm considering removing this other speed feature in a separate PR, because it's 1. buggy, and 2. very badly written (hardcoded values, no zero value handling).
Scrolling speed
I did not add a slider for the scrolling speed (when using the other analog stick of the gamepad), just because I find it fine and less anoying than the cursor speed. But it's up to suggestion for consistency.
Related to #452