Skip to content

Feat/trade core #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caniro merged 16 commits into from
Jun 24, 2025
Merged

Feat/trade core #179

caniro merged 16 commits into from
Jun 24, 2025

Conversation

@caniro
Copy link
Contributor

@caniro caniro commented Jun 24, 2025

✨ 작업내용

  • 체결 단일 성능 개선 (DB I/O 최소화)
  • 체결 알림 시점 변경 (주문 완전체결 시)

⚠️ 특별사항

  • QueryDSL 사용으로 인해, 실행 전 빌드하셔야 Q 클래스 생성되는 점 참고 부탁드립니다.

caniro added 16 commits June 16, 2025 14:01
@caniro
fix: 체결 성능테스트 정상화
350ce1c
@caniro
Merge branch 'dev' into feat/trade-core
3722624
@caniro
feat: 체결 완료 알림 개선(주문 완전체결 시점에 알림)
265d61d
@caniro
refactor: (성능개선) 체결 시 Wallet을 한번에 update 하도록 수정
6e6259c
@caniro
test: 체결 성능테스트 mariaDB 기준으로 수행되도록 변경
c90f92c
@caniro
refactor: (성능개선) 체결 시 Trade들을 모아서 한번에 저장하도록 변경
e253435
@caniro
refactor: (성능개선) userId로 wallet 조회 시 DB join으로 한번에 가져오도록 변경
9a3ba50
@caniro
refactor: (성능개선) userId로 wallet 조회 시 여러 레코드를 한번에 가져오도록 변경
62c43e3
@caniro
refactor: (성능개선) 체결 시 매도계좌 예수금 증가 로직 JPQL로 변경
f37dd2a
@caniro
refactor: (성능개선) 체결 시 매수지갑 잔고 증가 로직 QueryDSL로 변경
3339daf
@caniro
Merge branch 'dev' into feat/trade-core
948920c
@caniro
fix: account JPQL 수행 전 flush 되도록 변경(체결 시 order 저장되지 않던 이슈 해결)
9f9bd4b
@caniro
test: 테스트 시 order DB에 저장한 상태로 시작하도록 변경
4226762
@caniro
Merge branch 'dev' into feat/trade-core
8c3a48c
@caniro
fix: 체결 성능테스트 동시성 이슈 원인 제거
6213804
@caniro
Merge branch 'dev' into feat/trade-core
9242164
@caniro caniro requested review from BHyeonKim, Junh-b and bongj9 June 24, 2025 11:19
@caniro caniro self-assigned this Jun 24, 2025
@caniro caniro linked an issue Jun 24, 2025 that may be closed by this pull request
[BE] 체결 성능 개선 #168
Closed
1 task
@investfuture-sonarqube1
Copy link

investfuture-sonarqube1 bot commented Jun 24, 2025

Failed Quality Gate failed

  • 7 New Issues (is greater than 0)
  • 0.00% Coverage on New Code (is less than 80.00%)

Project ID: CleanEngine_cleanengine-be_2b6f2f63-fa39-426c-b9c7-8aa127fd14d8

View in SonarQube

@caniro caniro linked an issue Jun 24, 2025 that may be closed by this pull request
[BE] 체결 알림 로직 개선 #144
Closed
BHyeonKim
BHyeonKim approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@BHyeonKim BHyeonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 😃

@caniro caniro merged commit c3b6165 into dev Jun 24, 2025
1 check passed
@caniro caniro deleted the feat/trade-core branch July 16, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BHyeonKim BHyeonKim BHyeonKim approved these changes

@Junh-b Junh-b Awaiting requested review from Junh-b

@bongj9 bongj9 Awaiting requested review from bongj9

Assignees

@caniro caniro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BE] 체결 성능 개선 [BE] 체결 알림 로직 개선

3 participants

@caniro @BHyeonKim