Fix. Contacts Encoder. Simple precheck content before high-cost logic run. - #891
Open
alexandergull wants to merge 1 commit into
Open
alexandergull wants to merge 1 commit into
alexandergull wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified, and all reviewed files are covered.
Pull request overview
Optimizes contact shortcode encoding by prechecking content before running expensive processing.
Changes:
- Adds shared shortcode presence checks.
- Short-circuits unnecessary encoding and exclusion processing.
- Adds regression tests for fast paths and preserved behavior.
File summaries
| File | Description |
|---|---|
tests/ApbctWP/ContactsEncoder/Shortcodes/EmailEncoderShortCodePrecheckTest.php |
Tests precheck behavior and round trips. |
lib/Cleantalk/ApbctWP/ContactsEncoder/Shortcodes/ExcludedEncodeContentSC.php |
Applies prechecks to excluded shortcode handling. |
lib/Cleantalk/ApbctWP/ContactsEncoder/Shortcodes/EncodeContentSC.php |
Applies prechecks before encoding and restoration. |
lib/Cleantalk/ApbctWP/ContactsEncoder/Shortcodes/EmailEncoderShortCode.php |
Adds shared shortcode precheck logic. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #891 +/- ##
============================================
+ Coverage 30.59% 30.62% +0.03%
- Complexity 6639 6651 +12
============================================
Files 292 292
Lines 26493 26507 +14
============================================
+ Hits 8105 8119 +14
Misses 18388 18388 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
svedge
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/54678