Conversation
Owner
|
Will take a look at this in a bit. Again, feel free to ignore the codecov check, it's fine. |
Owner
|
Hmm, if I'm understanding this correctly, this is tying the feature behind a flag/option, which is the only way to configure whether it is sorted/not sorted? I was thinking of putting this as a standalone feature into the legend table (similar to how you can sort the process widget), as opposed to having to enable/disable it through a flag/option. |
Author
|
I see, that does seem like a better idea. |
Author
|
@ClementTsang I'd like to give this work another push to the finish line. Could you point me to the code which shows an example of adding the sorting to the TUI (i.e. the CPU%(c) 🔺 / 🔻 ) part)? |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:
Sorts the CPU Legend based on highest ranking CPU%.
Note, the colors are attached to the order of the entries rather than the CPUs themselves causing the CPU line graphs to constantly change color. I believe it would be important for this feature to ensure the colors are attached to the entries rather than the order of the entries.
Issue
If applicable, what issue does this address?
From #703 (comment)
Testing
If relevant, please state how this was tested. All changes must be tested to work:
Please also indicate which platforms were tested. All platforms directly affected by the change must be tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, etc.)