Skip to content

Add some averaged diagnostics#1898

Merged
simone-silvestri merged 18 commits into
mainfrom
ss/ocean-seaice-diagnostics
May 14, 2026
Merged

Add some averaged diagnostics#1898
simone-silvestri merged 18 commits into
mainfrom
ss/ocean-seaice-diagnostics

Conversation

@simone-silvestri
Copy link
Copy Markdown
Contributor

for the Oceananigans ocean and the ClimaSeaIce sea ice components

Copy link
Copy Markdown
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Were you able to run a simulation and verify that the diagnostics were generated as expected?

Comment thread ext/ClimaCouplerCMIPExt.jl
Comment thread ext/ClimaCouplerCMIPExt/seaice_diagnostics.jl Outdated
Comment thread ext/ClimaCouplerCMIPExt/seaice_diagnostics.jl Outdated
Comment thread ext/ClimaCouplerCMIPExt/seaice_diagnostics.jl Outdated
Comment thread ext/ClimaCouplerCMIPExt/ocean_diagnostics.jl Outdated
Comment thread src/Input.jl
help = "Iteration interval for printing progress information [`nothing`, `<:Integer`] (default: nothing)"
arg_type = Integer
default = nothing
"--ocean_diagnostic_interval"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's kind of annoying but when we add a new config option we also have to update input_test.jl, like we did here. We should change those tests to not require that - I'll open an issue

Copy link
Copy Markdown
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after CI passes

@simone-silvestri simone-silvestri merged commit 17da8fe into main May 14, 2026
13 of 14 checks passed
@simone-silvestri simone-silvestri deleted the ss/ocean-seaice-diagnostics branch May 14, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants