don't apply polar mask for ocean/ice interactions#1935
Merged
Conversation
juliasloan25
requested review from
akshaysridhar and
hgpeterson
and removed request for
hgpeterson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Running CMIP on main with strict bounds checking enforced results in an out-of-bounds memory access error. This comes from applying the polar mask to the momentum fluxes between ocean and sea ice. Because ocean and sea ice exist on the same grid, we don't need to apply the polar mask to their interactions (only to atmos-surface interactions).
This PR removes the polar mask from the ocean/sea ice interactions, and adds
check-bounds=yesto one CMIP run in CI, so that we can catch similar errors in the future.