You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Shorten simulation length from 1days to 3hours, which is enough to test the hourly checkpointing Removed this run. It wasn't even saving checkpoints, and checkpointing is tested more thoroughly by the restarts test.
Shorten simulation length from 600secs to 300secs; increase timesteps of some components to reduce computation (if this isn't enough, we can shorten it to 150secs). Note that even though we'll realistically want to run sims with the atmosphere having the smallest timestep, dt_atmos is the largest here because it is the most computationally demanding.
Removed this run. It was originally added for performance monitoring, but we have since removed the flamegraphs it used to generate. The profiling option of the benchmarks pipeline can now be used for more informative GPU profiling.
To-do
Content
I have read and checked the items on the review checklist.
Any thoughts on shortening the github actions CI now that that seems to be the bottleneck?
Good point. Right now the GHA run test/runtests.jl (10 mins) and also experiments/test/runtests.jl (50 mins). We could split these into two different workflows so they can run in parallel. The only thing to be mindful of there is that there is a quota for how many github runners we can use at once across the entire CliMA org.
Actually, we run experiments/test/runtests.jl in buildkite already (here), so we don't really need to also run it in GHA. I'll open a PR to remove it from GHA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
CI has gotten long again. This PR shortens the runtime of three of the longest runs, which currently take:
(taken from this build on main)
After this PR, the times are:
(taken from this build)
The changes to each config are the following:
Shorten simulation length from 1days to 3hours, which is enough to test the hourly checkpointingRemoved this run. It wasn't even saving checkpoints, and checkpointing is tested more thoroughly by the restarts test.To-do
Content