Skip to content

update SplitExplicitSolver calls#759

Merged
simone-silvestri merged 1 commit into
mainfrom
js/seaice-solver
Mar 5, 2026
Merged

update SplitExplicitSolver calls#759
simone-silvestri merged 1 commit into
mainfrom
js/seaice-solver

Conversation

@juliasloan25
Copy link
Copy Markdown
Member

The constructor for ClimaSeaIce's SplitExplicitSolver was changed in v0.4.4 from CliMA/ClimaSeaIce.jl#121 to fix a bug. The changes are propagated here.

@juliasloan25 juliasloan25 added the bug Something isn't working label Mar 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.91%. Comparing base (c70bba8) to head (b7b5ede).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/SeaIces/sea_ice_simulation.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #759       +/-   ##
===========================================
+ Coverage   14.67%   26.91%   +12.23%     
===========================================
  Files          63       67        +4     
  Lines        3516     3615       +99     
===========================================
+ Hits          516      973      +457     
+ Misses       3000     2642      -358     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simone-silvestri simone-silvestri merged commit e32e637 into main Mar 5, 2026
29 of 30 checks passed
@simone-silvestri simone-silvestri deleted the js/seaice-solver branch March 5, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants