Skip to content

Add new documentation for the package#114

Merged
simone-silvestri merged 40 commits into
mainfrom
ss/new-documentation
Feb 17, 2026
Merged

Add new documentation for the package#114
simone-silvestri merged 40 commits into
mainfrom
ss/new-documentation

Conversation

@simone-silvestri
Copy link
Copy Markdown
Collaborator

This PR add some docs for the SeaIceModel with references.

Copy link
Copy Markdown
Member

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I'll try to push some show/summary methods!

Comment on lines +15 to +17
\frac{\partial h}{\partial t} = w_u + w_b
```
where ``w_u`` and ``w_b`` are the interface velocities at the top (atmosphere-ice) and bottom
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's u and b meant to imply? "up" and "bottom"?
Can we do "top" and "bottom"? or "a" and "o" for ice-atmosphere and ice-ocean?

Copy link
Copy Markdown
Collaborator Author

@simone-silvestri simone-silvestri Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the "top" and "bottom". Let's do another PR for it because it changes source code

Comment thread docs/src/physics/thermodynamics.md
Comment thread docs/src/physics/dynamics_and_rheology.md
Comment thread docs/src/physics/dynamics_and_rheology.md Outdated
Comment thread docs/src/physics/dynamics_and_rheology.md Outdated
Comment thread docs/src/physics/dynamics_and_rheology.md Outdated
Comment thread docs/src/physics/dynamics_and_rheology.md
Comment thread docs/src/physics/dynamics_and_rheology.md
@navidcy navidcy added the 📜 documentation Improvements or additions to documentation label Feb 15, 2026
Comment thread docs/src/physics/dynamics_and_rheology.md Outdated
@navidcy navidcy self-requested a review February 15, 2026 22:48
Comment thread docs/src/physics/dynamics_and_rheology.md
@navidcy
Copy link
Copy Markdown
Member

navidcy commented Feb 16, 2026

I reverted some commits I made in the examples to avoid conflicts with #100.

@simone-silvestri
Copy link
Copy Markdown
Collaborator Author

Looks good, thanks @navidcy! I ll merge

@simone-silvestri simone-silvestri merged commit 5d1333b into main Feb 17, 2026
7 checks passed
@simone-silvestri simone-silvestri deleted the ss/new-documentation branch February 17, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📜 documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants