-
Notifications
You must be signed in to change notification settings - Fork 3
Snow model implementation #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
379112f
start with a snow model
simone-silvestri 4185f58
go ahead
simone-silvestri 740d08c
add
simone-silvestri f0608d0
add energy conservation test
simone-silvestri 76e2b62
remove freshwater fluxes
simone-silvestri d3c28b7
fix docs
simone-silvestri 2a584b6
typo
simone-silvestri 0cd7900
fix docs
simone-silvestri d8b6146
fix docs
simone-silvestri 1ffd610
correct docs typo
simone-silvestri 606dd43
Potential fix for pull request finding
simone-silvestri 9444d1e
Potential fix for pull request finding
simone-silvestri 094e1f5
Potential fix for pull request finding
simone-silvestri 95a2cc6
Merge branch 'main' into ss/snow-model
simone-silvestri 12678ca
address the review points
simone-silvestri db647b2
Merge branch 'main' into ss/snow-model
simone-silvestri ac9c743
remove the extra end
simone-silvestri e15240f
retrigger CI
simone-silvestri c522d20
fix method
simone-silvestri 1851851
fix ncdatasets tests
simone-silvestri dd786ef
remove the "ice" qualifier
simone-silvestri ad2d898
addressing more comments
simone-silvestri 6c7abe2
Merge remote-tracking branch 'origin/main' into ss/snow-model
simone-silvestri f458dcb
add IceSnowConductiveFlux where it should live
simone-silvestri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.