Skip to content

Fix NCDatasets extension for Julia 1.12 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ewquon wants to merge 1 commit into from
Closed

Fix NCDatasets extension for Julia 1.12 #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions ext/ClimaSeaIceNCDatasetsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,12 @@ default_sea_ice_attributes() = Dict(
"ℵ" => Dict("long_name" => "Sea ice concentration.", "units" => "-")
)

function __init__()
OCNE = Base.get_extension(Oceananigans, :OceananigansNCDatasetsExt)
if !isnothing(OCNE)
@eval begin
function $OCNE.default_output_attributes(model::SeaIceModel)
velocity_attrs = default_horizontal_velocity_attributes(model.grid)
tracer_attrs = default_sea_ice_attributes()
return merge(velocity_attrs, tracer_attrs)
end
end
OCNE = Base.get_extension(Oceananigans, :OceananigansNCDatasetsExt)
if !isnothing(OCNE)
function OCNE.default_output_attributes(model::SeaIceModel)
velocity_attrs = default_horizontal_velocity_attributes(model.grid)
tracer_attrs = default_sea_ice_attributes()
return merge(velocity_attrs, tracer_attrs)
Comment on lines +31 to +36
Copy link
Copy Markdown
Collaborator

@simone-silvestri simone-silvestri Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work because the extension is not loaded at compile time. We need CliMA/Oceananigans.jl#5469 and then extend the function in output_writers

end
end

Expand Down
Loading